Remove invalid service and simplify authentication validation

The service specific validation for `PaymentSetupAndVerification` was
useless as this service is not a valid service in `service_url_base`.

Removing it means that we where able to simplify the validation as it is
not service dependent anymore.

Author: Korri

lib/adyen/client.rb

@@ -145,8 +145,6 @@ def call_adyen_api(service, action, request_data, headers, version, _with_applic
       # get URL for requested endpoint
       url = service_url(service, action.is_a?(String) ? action : action.fetch(:url), version)
 
-      # make sure valid authentication has been provided
-      validate_auth_type(service, request_data)
 
       method = action.is_a?(String) ? 'post' : action.fetch(:method)
 
@@ -156,7 +154,7 @@ def call_adyen_api(service, action, request_data, headers, version, _with_applic
     # send request to adyen API with a given full URL
     def call_adyen_api_url(url, method, request_data, headers)
       # make sure valid authentication has been provided, without a specific service
-      validate_auth_type(nil, request_data)
+      validate_auth(request_data)
 
       # initialize Faraday connection object
       conn = Faraday.new(url, @connection_options) do |faraday|
@@ -343,18 +341,14 @@ def auth_type
       "basic"
     end
 
-    def validate_auth_type(service, request_data)
+    def validate_auth(request_data)
       # ensure authentication has been provided
       if @api_key.nil? && @oauth_token.nil? && (@ws_password.nil? || @ws_user.nil?)
         raise Adyen::AuthenticationError.new(
           'No authentication found - please set api_key, oauth_token, or ws_user and ws_password',
           request_data
         )
       end
-      if service == "PaymentSetupAndVerification" && @api_key.nil? && @oauth_token.nil? && @ws_password.nil? && @ws_user.nil?
-        raise Adyen::AuthenticationError.new('Checkout service requires API-key or oauth_token', request_data),
-              'Checkout service requires API-key or oauth_token'
-      end
     end
 
     # build the error message from the response payload

spec/client_spec.rb

@@ -537,6 +537,14 @@
 
       expect(request_body_sent).to eq(hash_data.to_json)
     end
+
+    it 'validates authentication is provided' do
+      client_without_auth = Adyen::Client.new(env: :test)
+
+      expect {
+        client_without_auth.call_adyen_api('Checkout', 'payments', {}, {}, '71')
+      }.to raise_error(Adyen::AuthenticationError, /No authentication found/)
+    end
   end
 
   describe '#call_adyen_api_url' do